This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
Add docs around WithAllowlistedMultiaddrs. Expose allowlist #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MarcoPolo
commented
Jul 3, 2022
MarcoPolo
commented
- Adds an example on how to use the with allowlisted multiaddr option.
- Adds a function that lets you get the allowlist object from the resource manager. Maybe this should be part of the core api, or maybe NewResourceManager should return a concrete type. I think it'll be easier to change this in a monorepo, but this should be work for now. It should be a small number of users using this right now.
Merged
marten-seemann
approved these changes
Jul 3, 2022
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
Yup! And they get executed during tests: https://go.dev/blog/examples |
41 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.